Skip to content

sync: from linuxdeepin/dtkwidget#163

Merged
18202781743 merged 1 commit intomasterfrom
sync-pr-679-nosync
Aug 14, 2025
Merged

sync: from linuxdeepin/dtkwidget#163
18202781743 merged 1 commit intomasterfrom
sync-pr-679-nosync

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#679

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • buttonexample.cpp中,connect函数的lambda表达式参数列表中移除了DGuiApplicationHelper::SizeMode类型,这可能会影响信号与槽的连接,需要确认是否意图如此修改。
  • main.cpp中,DApplication::setAttribute的调用被包裹在#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0))条件编译指令中,这表明代码可能不兼容Qt 6.0.0及以上版本。建议检查是否有必要支持旧版本的Qt。
  • dfontcombobox.cppdlineedit.cpp中,注释的格式不一致,建议统一注释风格。
  • dprintpreviewwidget.cpp中,DPrintPreviewWidget的构造函数现在接受一个parent参数,但之前的代码没有传递这个参数。需要确认这是否是预期的修改。
  • dstyle.cpp中,pixelMetric函数使用static_cast<uint32_t>(m)进行类型转换,这可能是为了确保类型安全,但需要确认是否有必要。
  • dstyleditemdelegate.cpp中,registerMetaType函数被标记为__attribute__((constructor)),这可能会导致在不同编译器或平台上行为不一致。建议使用Q_CONSTRUCTOR_FUNCTION宏来确保跨平台兼容性。
  • dtitlebareditpanel.cpp中,DCollapseWidget::updateMinimumValuecollapse函数中使用了qobject_cast,但没有检查返回值是否为nullptr,可能会导致潜在的空指针解引用。
  • ut_dcombobox.cpput_dtextedit.cpp中,QTest::qWaitForWindowExposed调用前使用了(void)进行强制类型转换,这可能是为了抑制未使用的变量警告,但需要确认这是否是必要的。

是否建议立即修改:

@github-actions
Copy link
Contributor

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/widgets/dstyleditemdelegate.cpp": [
        {
            "line": "  \brief 设置项 item 的集合列表 \a list, 只显示有 text 的 DViewItemActionList 集合",
            "line_number": 1538,
            "rule": "C128",
            "reason": "政治敏感词 | b231f13999"
        }
    ]
}

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#679
@github-actions
Copy link
Contributor

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/widgets/dstyleditemdelegate.cpp": [
        {
            "line": "  \brief 设置项 item 的集合列表 \a list, 只显示有 text 的 DViewItemActionList 集合",
            "line_number": 1538,
            "rule": "C128",
            "reason": "政治敏感词 | b231f13999"
        }
    ]
}

@18202781743 18202781743 merged commit 56812d2 into master Aug 14, 2025
13 of 14 checks passed
@18202781743 18202781743 deleted the sync-pr-679-nosync branch August 14, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments